Add check for incorrect constructor used #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of merging this? or just close the PR if you never want to. Thanks! |
|
The problem I have at the moment is the version of tinyioc in nancy has diverged from this one, which was never the idea, so I need to spend some time reconciling them before I bring in any more PRs, and I haven't had time to do that yet - doesn't mean they won't get added though :) |
|
Okay - My two PRs are adding additional tests for scenarios that caught me out when using TinyIoC so they shouldn't muddy the waters, but I understand your reluctance to merge new code. |
|
@grumpydev @richardhopton I don't see anything wrong with this pr. I'm going to merge it in. @grumpydev where are you referring in regards to Nancy? |
gkarabin
pushed a commit
to gkarabin/TinyIoC
that referenced
this pull request
Apr 16, 2020
…ctorFromAnotherType Add check for incorrect constructor used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.