Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added netstandard15, removed dotnet54 #94

Merged
merged 1 commit into from
May 27, 2016
Merged

added netstandard15, removed dotnet54 #94

merged 1 commit into from
May 27, 2016

Conversation

jchannon
Copy link
Contributor

No description provided.

@jchannon jchannon mentioned this pull request May 25, 2016
Closed
@niemyjski
Copy link
Collaborator

+1 can we get this merged in.

@niemyjski
Copy link
Collaborator

I found three issues that exited before your pr and I was hoping you could fix them quick because the chances of getting a pull request accepted to fix them is slim to none (as @grumpydev is pretty busy) :\

  • replace TinyIoCInstantiationTypeException with TinyIoCRegistrationException to fix doc issues
  • replace RegisterImplementation to RegisterType to fix doc issues.
  • PORTABLE compiler directive check also needs to #undef SERIALIZABLE as it won't compile without it..

@grumpydev grumpydev merged commit 84a016f into grumpydev:master May 27, 2016
@niemyjski
Copy link
Collaborator

Thanks for merging this.. I took this code and did even more work to bring it down to net standard 1.2

@niemyjski
Copy link
Collaborator

I'll do a new pr with that

@j0nscalet j0nscalet mentioned this pull request Jul 11, 2016
Open
@malachib malachib mentioned this pull request Aug 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchannon @niemyjski @grumpydev