This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Evaluation of latest_node_version outside of ternary operation (unknown values during apply) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veggiemonk
requested review from
autero1,
robmorgan and
yorinasub17
as code owners
|
Hmmm I wonder if we should merge this PR or wait for a TF patch release and bump the minimum version? @yorinasub17 @rileykarson any thoughts? I guess its breaking now, so we should document this fix, release it and possibly undo it in the future. |
|
I think we should apply the fix now. I don't see a reason to undo it in the future, breaking a ternary case to an intermediary local feels like a positive change. |
|
Ok I'll do a patch release then 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in terraform which prevent the evaluation of data.google_container_engine_versions.location if it is in a ternary operation.
The equivalent problem is hashicorp/terraform#21465
Since terraform team is working on it, I felt like I should let you know.
This PR contains the workaround that bug.
Feel free to discard this PR.
This is to open a discussion on how to deal with bug in terraform.
Have a great day,
Julien