-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vault support for sops encryption mechanism #1564
Added vault support for sops encryption mechanism #1564
Conversation
@yorinasub17 @brikis98 any updates on this please? |
Thanks for the PR! Apologies for the delay. We are super buried right now. We'll get to this as soon as we can. |
This would be super useful. |
@brikis98 Hello. Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR and your patience as we got around to reviewing this!
I see the updates to go.mod
... But there should be a corresponding auto-generated update to go.sum
as well. Could you include that in the PR?
@brikis98 I have updated go.sum, could you please check it. |
7e57e70
to
2ac00c0
Compare
Hi @teamfighter, I have this issue here #1629. Could you bump it 1.7.0 on this PR? That way you would be fixing my problem too. Thanks. |
This will require additional testing. I'll try to do this today. |
3c628c7
to
2ac00c0
Compare
@brikis98 I resolved merge conflicts and bumped sops to 3.7.0, vault to 1.7.0 Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll kick off tests now.
As I can see, unit tests are failed. Should I fix something? If so, what exactly? |
I think this is the error:
|
I executed |
Re-running... |
This pull request related to #1562
As used
go.mozilla.org/sops/v3 v3.5.0
does not support hashicorp vault, I bumped this go module tov3.6.1
Also added
github.com/hashicorp/vault v1.6.2
to avoid ambiguous import error while building binary.I ran
go test -v ./...
, here is the output in gist.I hope provided information is enough to merge this PR.