Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch log level of terragrunt dependency fetching informational messages #1628

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

yorinasub17
Copy link
Contributor

Related to #1625

This updates the informational messages related to dependency fetching optimizations to info log level from warning. I initially made these warning to make it more visible, but in hindsight these should have been info level because they are purely informational.

Warning indicates that something might be amiss and the user needs to make changes. In this case, there is probably nothing wrong here because there are many valid use cases of setting up terragrunt without remote_state blocks (e.g., if your project uses remote state that is not backed by s3 or gcs). Thus info log level seems more appropriate for these messages.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner April 2, 2021 01:52
brikis98
brikis98 previously approved these changes Apr 2, 2021
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it even be Info? Or Debug? That is, what percentage of users need to see this message at all, by default?

@yorinasub17
Copy link
Contributor Author

Should it even be Info? Or Debug? That is, what percentage of users need to see this message at all, by default?

Good point - updated to use debug: 6d40576

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Going to merge this in now.

@yorinasub17 yorinasub17 merged commit 46984d5 into master Apr 6, 2021
@yorinasub17 yorinasub17 deleted the yori-loglevel-of-dependencyfetching branch April 6, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants