-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch log level of terragrunt dependency fetching informational messages #1628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it even be Info
? Or Debug
? That is, what percentage of users need to see this message at all, by default?
Good point - updated to use debug: 6d40576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for review! Going to merge this in now. |
Related to #1625
This updates the informational messages related to dependency fetching optimizations to info log level from warning. I initially made these warning to make it more visible, but in hindsight these should have been
info
level because they are purely informational.Warning indicates that something might be amiss and the user needs to make changes. In this case, there is probably nothing wrong here because there are many valid use cases of setting up terragrunt without
remote_state
blocks (e.g., if your project uses remote state that is not backed bys3
orgcs
). Thus info log level seems more appropriate for these messages.