Fixing behavior of --terragrunt-strict-include when no --terragrunt-include-dir flags are included
#1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celestialorb
force-pushed
the
bugfix/1600-strict-include-fix
branch
from
2aa1e8d to
90d7e69
Compare
celestialorb
changed the title
--terragrunt-strict-include when no --terragrunt-include-dir flags are included--terragrunt-strict-include when no --terragrunt-include-dir flags are included
|
Added in basic tests for this behavior and was able to get them to pass locally on my machine after a minor change as Go wasn't picking up the |
brikis98
reviewed
Apr 7, 2021
|
@brikis98 Yep, I'll find some time to do that later tonight or tomorrow, thanks! |
|
@brikis98 Added a statement to the docs about the new behavior of the |
brikis98
approved these changes
Apr 12, 2021
|
Tests passed! Merging now. |
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
1 task
1 task
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the behavior of Terragrunt when the
--terragrunt-strict-includeflag is supplied without any--terragrunt-include-dirflags.The expected behavior is that Terragrunt will evaluate to not run on any modules in this case, but the current behavior is that it will run over all modules of the working directory.
This is to address #1600.