-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --terragrunt-source-map #1674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Just a few questions in the PR. Also, two more here:
- Does it make sense to deprecate
--terragrunt-source
? - Should we support an env var like
TERRAGRUNT_SOURCE_MAP
?
Let's wait a little bit for
What would be the syntax for specifying multiple source mappings via env var? |
That's a good point.
Delimiter separated list? The delimiter could be space or semicolon or something else not commonly found in URLs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impl LGTM! Feel free to make the call on env var support (or add in another PR or file issue to track).
Thanks for review! I'll go ahead and merge this in + release it, and then open a new PR for the env var fix. |
Fixes #1138
This implements the
--terragrunt-source-map
feature described in the ticket linked above. Note the following differences with the issue description:--terragrunt-source-map
uses standard unix CLI kv definition. That is, it uses--terragrunt-source-map source=dest
instead of--terragrunt-source-map source:dest
.