Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multierror #1703

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Conversation

derom
Copy link
Contributor

@derom derom commented Jun 7, 2021

This PR addresses #1482

Here is the changes in output.

Previous output:

ERRO[0000] Hit multiple errors:
Hit multiple errors:
exit status 1 

New output:

ERRO[0000] 1 error occurred:
	* exit status 1

or more detailed example
Previous output:

ERRO[0000] Module /<basePath>/bastion/storage has finished with an error: Hit multiple errors:
Hit multiple errors:
exit status 1  prefix=[/<basePath>/bastion/storage] 
ERRO[0000] Dependency /<basePath>/bastion/storage of module /<basePath>/bastion/compute just finished with an error. Module /<basePath>/bastion/compute will have to return an error too.  prefix=[/<basePath>/bastion/compute] 
ERRO[0000] Module /<basePath>/bastion/compute has finished with an error: Cannot process module Module /<basePath>/bastion/compute (excluded: false, dependencies: [/<basePath>/bastion/storage]) because one of its dependencies, Module /<basePath>/bastion/storage (excluded: false, dependencies: []), finished with an error: Hit multiple errors:
Hit multiple errors:
exit status 1  prefix=[/<basePath>/bastion/compute] 
ERRO[0000] Encountered the following errors:
Hit multiple errors:
Hit multiple errors:
exit status 1
Cannot process module Module /<basePath>/bastion/compute (excluded: false, dependencies: [/<basePath>/bastion/storage]) because one of its dependencies, Module /<basePath>/bastion/storage (excluded: false, dependencies: []), finished with an error: Hit multiple errors:
Hit multiple errors:
exit status 1 

New output:

ERRO[0000] Module /<basePath>/bastion/storage has finished with an error: 1 error occurred:
	* exit status 1
  prefix=[/.../bastion/storage] 
ERRO[0000] Dependency /<basePath>/bastion/storage of module /<basePath>/bastion/compute just finished with an error. Module /<basePath>/bastion/compute will have to return an error too.  prefix=[/<basePath>/bastion/compute] 
ERRO[0000] Module /<basePath>/bastion/compute has finished with an error: Cannot process module Module /<basePath>/bastion/compute (excluded: false, dependencies: [/<basePath>/bastion/storage]) because one of its dependencies, Module /<basePath>/bastion/storage (excluded: false, dependencies: []), finished with an error: 1 error occurred:
	* exit status 1
  prefix=[/<basePath>/bastion/compute] 
ERRO[0000] 2 errors occurred:
	* Cannot process module Module /<basePath>/bastion/compute (excluded: false, dependencies: [/<basePath>/bastion/storage]) because one of its dependencies, Module /<basePath>/bastion/storage (excluded: false, dependencies: []), finished with an error: 1 error occurred:
	* exit status 1


	* exit status 1

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Changes LGTM! Let me kick off a regression build, and if it passes, we can merge this in.

cli/cli_app.go Outdated Show resolved Hide resolved
@yorinasub17
Copy link
Contributor

Looks like there is a build failure. Specifically, the check at https://github.com/gruntwork-io/terragrunt/blob/pull-request-1703/test/integration_test.go#L1502 and https://github.com/gruntwork-io/terragrunt/blob/pull-request-1703/test/integration_test.go#L1711 are failing with:

Object expected to be of type multierror.Error, but was *multierror.Error

@derom
Copy link
Contributor Author

derom commented Jun 11, 2021

@yorinasub17 my bad, I thought it was a glitch during my local run :) Fixed

@yorinasub17
Copy link
Contributor

Thanks for updating! Just kicked off a build.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build passed, so will go ahead and merge this in. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants