Share Env attributes with cfgOptions.
#2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlepere-everlaw
requested review from
yorinasub17,
zackproser,
rhoboat and
denis256
as code owners
In gruntwork-io#1823, functionality was added to check module dependencies during destroy operations. This included creating a fresh `TerragruntOptions` object [1] which, by default, has an empty map for the `Env` attribute [2]. This means we're losing all environment variables when checking for dependencies. [1] https://github.com/gruntwork-io/terragrunt/pull/1823/files#diff-2ce1e65bb8a23011007dae779c8bacbc45d28560b1bc4e7dc1079f52fd22cf14R504 [2] https://github.com/gruntwork-io/terragrunt/blob/7788a525ab61641211e3f8a127ed53b450e96bc8/options/options.go#L256
jlepere-everlaw
force-pushed
the
bug/pass-env-in-terragrunt-option
branch
from
d92112c to
86785a3
Compare
|
I've verified this change locally with |
denis256
approved these changes
Sep 13, 2022
|
Thanks, @denis256! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1823, functionality was added to check module dependencies during destroy operations. This included creating a fresh
TerragruntOptionsobject which, by default, has an empty map for theEnvattribute. This means we're losing all environment variables when checking for dependencies.Fixes #2273.
Release Notes (draft)
Updated
FindWhereWorkingDirIsIncludedto includeEnvin theTerragruntOptionsobject for validating module dependencies for destroy operations.