#2347 - add --terragrunt-global-cache support to run_cmd #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etiene
reviewed
Dec 1, 2022
| @@ -685,6 +685,12 @@ carrot | |||
| * Output contains multiple times `uuid3`, +1 more output comparing to `uuid1` and `uuid2` - because `uuid3` is declared in locals and inputs which add one more evaluation | |||
| * Output contains only once `uuid4` since it is declared only once in `inputs`, `inputs` is not evaluated twice | |||
|
|
|||
| You can modify this caching behavior to ignore the existing directory if you know the command you are running is not dependent on the current directory path. To do so, use the special `--terragrunt-global-cache` argument which must be passed as one of the first arguments to `run_cmd()` (and can be combined with `--terragrunt-quiet` in any order): | |||
There was a problem hiding this comment.
Thanks for the PR! Could you let me know how you tested this behavior? Looking at the code above it doesn't look like they can be combined in any order.
There was a problem hiding this comment.
That's what the for loop and switch statement does. It consumes the arguments that match in the switch statement. It doesn't matter which order they occur, they just have to be the first entries.
I tested manually to check the performance difference as shown in the linked issue. We could add additional tests here to verify both can be specified in any order if that helps.
denis256
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2347 and #2184.
This adds a new
--terragrunt-global-cacheoption torun_cmdthat caches the command globally instead of relative to the directory it is run from.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added
--terragrunt-global-cacheoption forrun_cmdto cache output globally instead of per directory.Migration Guide