Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added handling of no outputs in render-json execution #2635

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Added handling of no outputs in render-json execution #2635

merged 3 commits into from
Jul 18, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Jul 12, 2023 •
edited
Loading

Description

Included changes:

  • updated HCL decoding to handle cases when inputs reference not existing outputs.

Fixes #2631.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Updated render-json to handle output values from not applied dependencies.

Migration Guide

@denis256 denis256 changed the title [WIP] Added handling of no outputs in render-json execution Added handling of no outputs in render-json execution Jul 12, 2023
@denis256 denis256 marked this pull request as ready for review July 12, 2023 20:02
@denis256 denis256 requested a review from marinalimeira July 12, 2023 20:02
marinalimeira
marinalimeira approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@marinalimeira marinalimeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The JSON is being generated now!

@denis256 denis256 merged commit 1137830 into master Jul 18, 2023
@denis256 denis256 deleted the bug/render-json-2631 branch July 18, 2023 09:07
hugorut pushed a commit to infracost/terragrunt that referenced this pull request Oct 10, 2023
@denis256 @hugorut
Added handling of no outputs in render-json execution (gruntwork-io#2635
f0e36c0 
)

* Add check for access fields errors in render-json

* Add test for handling inputs which are referencing not existing fields

* Cleanup
hugorut pushed a commit to infracost/terragrunt that referenced this pull request Oct 10, 2023
@denis256 @hugorut
Added handling of no outputs in render-json execution (gruntwork-io#2635
e89904a 
)

* Add check for access fields errors in render-json

* Add test for handling inputs which are referencing not existing fields

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinalimeira marinalimeira marinalimeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

render-json fails when there is not a fallback to the output
2 participants
@denis256 @marinalimeira