-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CircleCI config to sign MacOS binaries #2661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of codesign for both binaries:
|
This was referenced Aug 11, 2023
MoonMoon1919
approved these changes
Aug 11, 2023
denis256
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test TestErrorExplaining
I fixed in master, in another PR
Thank you both for reviewing! |
hugorut
pushed a commit
to infracost/terragrunt
that referenced
this pull request
Oct 10, 2023
* Add config of circleci to sign macos binaries * Add go orb * Persist workspace between jobs * Fix spacing in persist_to_workspace
hugorut
pushed a commit
to infracost/terragrunt
that referenced
this pull request
Oct 10, 2023
* Add config of circleci to sign macos binaries * Add go orb * Persist workspace between jobs * Fix spacing in persist_to_workspace
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are already able to sign the binaries of internal projects, like patcher-cli and terrapatch-cli.
I am replicating the same process in Terragrunt, the MacOS binaries will be signed and notarized before generating the
sha256sum
.Related:
Test release: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.48.7-test-signing-binaries
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Signing MacOS binaries from now on! 🎉