Prevent parsing of excluded modules #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| globPath = filepath.Join(basePath, globPath) | ||
| } | ||
|
|
||
| matches, err := zglob.Glob(globPath) |
There was a problem hiding this comment.
What is the desired behavior here if err is not nil?
There was a problem hiding this comment.
Just skip this globPath as it was before
terragrunt/configstack/module.go
Lines 182 to 187 in 40e0d4b
Perhaps there is a reason for this behaviour, I don't know, but I would check the correctness of this path and return an error in cases of non-existence.
There was a problem hiding this comment.
Do you think we should change this behaviour?
There was a problem hiding this comment.
Makes sense, no worries! Let's leave it for now
MoonMoon1919
approved these changes
Aug 15, 2023
|
Thanks for the review @MoonMoon1919! |
|
Resolved in v0.50.1 release. |
RaphSku
pushed a commit
to RaphSku/terragrunt
that referenced
this pull request
Aug 16, 2023
* fix: prevent parsing of excluded modules * fix: unit tests * chore: add unit test --------- Co-authored-by: Levko Himins <[email protected]>
hugorut
pushed a commit
to infracost/terragrunt
that referenced
this pull request
Oct 10, 2023
* fix: prevent parsing of excluded modules * fix: unit tests * chore: add unit test --------- Co-authored-by: Levko Himins <[email protected]>
hugorut
pushed a commit
to infracost/terragrunt
that referenced
this pull request
Oct 10, 2023
* fix: prevent parsing of excluded modules * fix: unit tests * chore: add unit test --------- Co-authored-by: Levko Himins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent parsing of excluded modules. For example, these modules may have invalid syntax or incomplete configuration, causing terragrunt to fail when parsed.
Related Issues
Fixes #2167