-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reverting to asserts for non error checking assertions #3341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Have to fix some tests, so I moved the PR into WIP. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gruntwork-io/terragrunt](https://togithub.com/gruntwork-io/terragrunt) | patch | `v0.66.6` -> `v0.66.8` | | [gruntwork-io/terragrunt](https://togithub.com/gruntwork-io/terragrunt) | patch | `0.66.6` -> `0.66.8` | --- ### Release Notes <details> <summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary> ### [`v0.66.8`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.66.8) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.66.7...v0.66.8) #### What's Changed - chore: Bumping go version used during builds to `1.22` by [@​yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3346](https://togithub.com/gruntwork-io/terragrunt/pull/3346) **Full Changelog**: gruntwork-io/terragrunt@v0.66.7...v0.66.8 ### [`v0.66.7`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.66.7) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.66.6...v0.66.7) #### What's Changed - fix: Reverting to asserts for non error checking assertions by [@​yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3341](https://togithub.com/gruntwork-io/terragrunt/pull/3341) - fix: Updated documentation for --terragrunt-graph-root by [@​denis256](https://togithub.com/denis256) in [https://github.com/gruntwork-io/terragrunt/pull/3344](https://togithub.com/gruntwork-io/terragrunt/pull/3344) - fix: Fixing remote state init skip by [@​yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3345](https://togithub.com/gruntwork-io/terragrunt/pull/3345) - chore: Adding `test` Lint Presets by [@​yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/3340](https://togithub.com/gruntwork-io/terragrunt/pull/3340) **Full Changelog**: gruntwork-io/terragrunt@v0.66.6...v0.66.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/akrantz01/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description
I went a bit too far with the changes in #3334.
It's inconvenient for developers to always use
require
. This updates the change so that they're only replced fromassert
when they evaluate errors.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Updated tests.