Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing output STDOUT logs to stdout #3409

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

levkohimins
Copy link
Contributor

@levkohimins levkohimins commented Sep 16, 2024

Description

Without the --terragrunt-forward-tf-stdout flag, STDOUT level log entries were sent to stdout. They mixed with the JSON output, causing parsing issues in the user's workflow.

Modifying terraform/log.go file does not relate to this issue, just a small code refactoring.

Fixes #3367.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@levkohimins levkohimins marked this pull request as ready for review September 16, 2024 15:49
@levkohimins levkohimins changed the title Fixing output **STDOUT** logs to stdout Fixing output STDOUT logs to stdout Sep 16, 2024
terraform/log.go Outdated Show resolved Hide resolved
Co-authored-by: Yousif Akbar <[email protected]>
@levkohimins levkohimins merged commit 64baa28 into main Sep 16, 2024
4 of 5 checks passed
@levkohimins levkohimins deleted the bug/output-log-to-stdout branch September 16, 2024 16:04
akrantz01 referenced this pull request in akrantz01/homelab Sep 16, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[gruntwork-io/terragrunt](https://redirect.github.com/gruntwork-io/terragrunt)
| patch | `v0.67.5` -> `v0.67.6` |
|
[gruntwork-io/terragrunt](https://redirect.github.com/gruntwork-io/terragrunt)
| patch | `0.67.5` -> `0.67.6` |

---

### Release Notes

<details>
<summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary>

###
[`v0.67.6`](https://redirect.github.com/gruntwork-io/terragrunt/releases/tag/v0.67.6)

[Compare
Source](https://redirect.github.com/gruntwork-io/terragrunt/compare/v0.67.5-beta2024091201...v0.67.6)

#### What's Changed

-   Allow pre-release versions to pass version constraints.
- Fixing output **STDOUT** logs to `stdout`. Without the
`--terragrunt-forward-tf-stdout` flag, **STDOUT** level log entries were
sent to `stdout`. They mixed with the JSON output and could cause
parsing issues in the user's workflow.

#### Related links

-
[https://github.com/gruntwork-io/terragrunt/pull/3405](https://redirect.github.com/gruntwork-io/terragrunt/pull/3405)
-
[https://github.com/gruntwork-io/terragrunt/pull/3409](https://redirect.github.com/gruntwork-io/terragrunt/pull/3409)

**Full Changelog**:
gruntwork-io/terragrunt@v0.67.5...v0.67.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/akrantz01/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.67.0 makes STDOUT output in log format
2 participants