Custom Log Formatting #3537
Custom Log Formatting #3537
Conversation
Co-authored-by: Yousif Akbar <[email protected]>
options/options.go
Outdated
| @@ -128,7 +129,7 @@ type TerragruntOptions struct { | |||
| // Disable Terragrunt colors | |||
| DisableLogColors bool | |||
|
|
|||
| // Output Terragrunt logs in JSON format | |||
| // Output Terragrunt logs in JSON formatter | |||
There was a problem hiding this comment.
Format was right here. Is this an accidental find and replace?
There was a problem hiding this comment.
Oh yeah, that was by accident when I made a replacement throughout the code.
| } | ||
| } | ||
|
|
||
| func (color *gradientColor) Value(text string) ColorValue { |
There was a problem hiding this comment.
I'm not following how this is implemented, but probably just because I'm bad at golang.
Can you confirm that this will result in color transitioning from one color to another, like this?
https://upload.wikimedia.org/wikipedia/commons/thumb/f/fa/Linear-gradient.svg/640px-Linear-gradient.svg.png
Do not implement this now, but I wonder if in the future we could have a user specify what the start and end colors would be.
There was a problem hiding this comment.
We already discussed this in a call conversation. This can works as gradient, we need just to fill the slice with gradient colors.
| **Environment Variable**: `TERRAGRUNT_LOG_CUSTOM_FORMAT`<br/> | ||
| **Requires an argument**: `--terragrunt-log-custom-format <LOG_CUSTOM_FORMAT>`<br/> | ||
|
|
||
| This allows you to specify which information you want to output. It works a little bit like printf format. |
There was a problem hiding this comment.
| This allows you to specify which information you want to output. It works a little bit like printf format. | |
| This allows you to customize logging however you like. |
pkg/log/options.go
Outdated
| return func(logger *logger) { | ||
| logger.Logger.SetFormatter(formatter) | ||
| logger.Logger.SetFormatter(&logruFormatter{Formatter: formatter}) |
There was a problem hiding this comment.
I'm confused by this. Why is this called logruFormatter?
There was a problem hiding this comment.
This is a typo. Fixed and added a comment.
|
Resolved in v0.68.15 release. |
Description
The PR adds two flags:
--terragrunt-log-format [bare | pretty | json | keyvalue]--terragrunt-log-custom-format "%time %level %prefix %msg"Context
https://linear.app/gruntwork/issue/TG-419/support-deep-log-format-customization
Closes #3431
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide