Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add put method into AWS Secrets Manager helper interface. #1466

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat: Add put method into AWS Secrets Manager helper interface. #1466

merged 1 commit into from
Nov 20, 2024

Conversation

forjor
Copy link
Contributor

@forjor forjor commented Nov 8, 2024

Description

Adds missing method to the AWS Secrets Manager helpers defined in #578 .

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs. (None present for existing methods in file, the method names explain themselves well)
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added Put method for AWS Secrets Manager helper [X].

@forjor forjor requested a review from denis256 as a code owner November 8, 2024 15:57
james03160927
james03160927 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change LGTM. Waiting for test result.

@james03160927 james03160927 merged commit 4f95711 into gruntwork-io:master Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@denis256 denis256 Awaiting requested review from denis256

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forjor @james03160927