glib: fix UB in VariantStrIter::impl_get #1343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an immutable reference (&p) to a function that mutates the data behind the pointer violates Rust's invariants.
This causes multiple tests in the test suite to crash when compiling it with optimizations (either
--release
mode or withopt-level
of 2 or 3) with recent Rust versions, which is easy to reproduce, especially with nightly Rust:Looks like this wasn't caught earlier because the wrapped C function is variadic and there's less type checking happening because of that.