Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vulnerability api #1147

Merged
merged 5 commits into from
Aug 16, 2023
Merged

update vulnerability api #1147

merged 5 commits into from
Aug 16, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Aug 14, 2023

Description of the PR

  • update server side graphQL
  • fix spacing
  • remove novuln node
  • regen based on new api
  • delete cve,ghsa,osv
  • update client side api
  • fix assembler and backend interface
  • change vulnerabilityMetadata to scanMetadata for certifyVuln
  • add vulnerability to inmem
  • update vuln and equal vuln for inmem
  • update certifyVuln and add in missing unit tests
  • update test
  • comment out neo4j
  • udpate ingest and unknown cli
  • update vuln cli and remove old arango
  • udpate arango for vulnerability
  • update vuln parser and tests
  • update vex parser
  • fix lint
  • update examples
  • fix noVuln case
  • fix vuln cli
  • fix preloads for vulnerabilities
  • enforce lowercase in resolver and address other comments

fixes issue #1097

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 changed the title update vulnerability api (#1141) update vulnerability api Aug 14, 2023
@pxp928 pxp928 linked an issue Aug 14, 2023 that may be closed by this pull request
@pxp928 pxp928 force-pushed the vuln-gql-change branch 2 times, most recently from 95c3994 to 0c26a20 Compare August 14, 2023 15:12
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides minor comment on novuln, rest reviewed in #1141

Copy link
Member

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just some minor questions.

pkg/assembler/backends/inmem/backend.go Show resolved Hide resolved
pkg/assembler/backends/inmem/vulnerability.go Outdated Show resolved Hide resolved
pxp928 and others added 5 commits August 16, 2023 12:57
* update server side graphQL

Signed-off-by: pxp928 <[email protected]>

* fix spacing

Signed-off-by: pxp928 <[email protected]>

* remove novuln node

Signed-off-by: pxp928 <[email protected]>

* regen based on new api

Signed-off-by: pxp928 <[email protected]>

* delete cve,ghsa,osv

Signed-off-by: pxp928 <[email protected]>

* update client side api

Signed-off-by: pxp928 <[email protected]>

* fix assembler and backend interface

Signed-off-by: pxp928 <[email protected]>

* change vulnerabilityMetadata to scanMetadata for certifyVuln

Signed-off-by: pxp928 <[email protected]>

* add vulnerability to inmem

Signed-off-by: pxp928 <[email protected]>

* update vuln and equal vuln for inmem

Signed-off-by: pxp928 <[email protected]>

* update certifyVuln and add in missing unit tests

Signed-off-by: pxp928 <[email protected]>

* update test

Signed-off-by: pxp928 <[email protected]>

* comment out neo4j

Signed-off-by: pxp928 <[email protected]>

* udpate ingest and unknown cli

Signed-off-by: pxp928 <[email protected]>

* update vuln cli and remove old arango

Signed-off-by: pxp928 <[email protected]>

* udpate arango for vulnerability

Signed-off-by: pxp928 <[email protected]>

* update vuln parser and tests

Signed-off-by: pxp928 <[email protected]>

* update vex parser

Signed-off-by: pxp928 <[email protected]>

* fix lint

Signed-off-by: pxp928 <[email protected]>

* update examples

Signed-off-by: pxp928 <[email protected]>

* fix noVuln case

Signed-off-by: pxp928 <[email protected]>

* fix vuln cli

Signed-off-by: pxp928 <[email protected]>

* fix preloads for vulnerabilites

Signed-off-by: pxp928 <[email protected]>

* enforce lowercase in resolver and address other comments

Signed-off-by: pxp928 <[email protected]>

---------

Signed-off-by: pxp928 <[email protected]>
Signed-off-by: pxp928 <[email protected]>
Signed-off-by: pxp928 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CertifyVuln should be scanner/db-agnostic
4 participants