add configuration of Bundler env, default to new behavior #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -297,7 +297,7 @@ | |||
| let(:options) { { cmd: "rspec" } } | |||
| it "uses the default" do | |||
| expect(Guard::RSpec::RSpecProcess).to receive(:new). | |||
| with(anything, %r{/tmp/rspec_guard_result$}).and_return(process) | |||
| with(anything, %r{/tmp/rspec_guard_result$}, options).and_return(process) | |||
soberstadt
force-pushed
the
fix-bundle-env
branch
from
4049a8f to
07235a0
Compare
|
Awesome, thanks! I'll release this soon. I doubt this will affect many users - those with problems will now not have them anymore. |
|
Released as v4.2.7. |
|
Thank you for this! We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is designed based on @e2's suggestion in #369. Bundler deprecated
with_clean_envin 1.12.x and has stopped working for me. This adds the configuration of which method to use when executing the rspec cmd. The new default with be to usewith_original_envbased on the deprecation notice: https://github.com/bundler/bundler/blob/v1.12.5/lib/bundler.rb#L208I'm wondering if this should include an upgrade message for anyone bumping to this version.