Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is unpause still valid? #550

Closed
ls5302 opened this issue Dec 23, 2021 · 3 comments · Fixed by #551
Closed

Is unpause still valid? #550

ls5302 opened this issue Dec 23, 2021 · 3 comments · Fixed by #551
Assignees
@ColinDKelley
Milestone
v3.7.1

Comments

@ls5302
Copy link

ls5302 commented Dec 23, 2021 •
edited
Loading

I'm using Listen 3.5.0, and calling the documented unpause method throws an exception. I've changed the code to use start and all appears well, but wanted to understand if unpause should work too. Searching for the unpause string in the Gem lib directory does not find anything. Not a big problem but maybe the documentation needs to be updated.
@ColinDKelley
Copy link
Collaborator

Hi @ls5302,

Thanks for reporting this. It looks like unpause was removed in favor of simply calling start again when you want to leave the paused state and return to processing_events. I'll make a quick PR to fix the documentation.

ColinDKelley added a commit to Invoca/listen that referenced this issue Dec 30, 2021
@ColinDKelley
issue guard#550: fix README to document start rather than unpause
573a1a3
@ColinDKelley
Copy link
Collaborator

@ls5302 Look good? #551

@ColinDKelley ColinDKelley mentioned this issue Dec 30, 2021
Closed
ColinDKelley added a commit that referenced this issue Dec 31, 2021
@ColinDKelley
issue #550: fix README to document start rather than unpause
177125d
@ColinDKelley ColinDKelley added this to the v3.7.1 milestone Jan 13, 2022
@ColinDKelley ColinDKelley self-assigned this Jan 13, 2022
@ColinDKelley
Copy link
Collaborator

Fixed in v3.7.1.

@ColinDKelley ColinDKelley linked a pull request Jan 13, 2022 that will close this issue
issue #550: fix README to document start rather than unpause #551
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ColinDKelley ColinDKelley

Labels
None yet
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging a pull request may close this issue.

issue #550: fix README to document start rather than unpause Invoca/listen
2 participants
@ColinDKelley @ls5302