Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signal handling #200

Merged
merged 3 commits into from
Mar 5, 2014
Merged

Remove signal handling #200

merged 3 commits into from
Mar 5, 2014

Conversation

thibaudgg
Copy link
Member

  • Only use signal handling in bin/listen and let Listen user to handle signal stuff themselves.
  • Improve Listen stopping

@thibaudgg thibaudgg mentioned this pull request Mar 5, 2014
@swistak
Copy link
Contributor

swistak commented Mar 5, 2014

Looks good!

@thibaudgg
Copy link
Member Author

@nex3 any comment before I merge it?

@swistak
Copy link
Contributor

swistak commented Mar 5, 2014

Like I've said looks ok. Passes test. I think it's good to merge.

thibaudgg added a commit that referenced this pull request Mar 5, 2014
@thibaudgg thibaudgg merged commit 2bba316 into master Mar 5, 2014
@thibaudgg thibaudgg deleted the remove_signal_handling branch March 5, 2014 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants