Change the commentingStage value to PROD
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deedeeh
changed the title
deedeeh
changed the title
commentingStage value to PROD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR changes commentingStage value to PROD for
actions-riff-raff@v4in theaction.yaml.When anyone upgrades
guardian/actions-static-sitefrom v2 to v3 that also upgrades automatically toguardian/actions-riff-raff@v4which by default has commentingStage as an input with a default value CODE but static-site doesn't have a CODE environment that's why we need to change this input to be PROD.As you can see from the screenshot below it failed after 0s with CODE.
The Github actions comment that got the riff-raff Deploy build number automatically has CODE as environment which you can currently see in this PR https://github.com/guardian/deacronym/pull/15