Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java version - see guardian/gha-scala-library-release-workflow#36 #209

Merged
merged 2 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:

# Configuring caching is also recommended.
# See https://github.com/actions/setup-java
- name: Setup Java 11
uses: actions/setup-java@v3
- name: Setup Java
uses: actions/setup-java@v4
with:
java-version: '11'
java-version: '21'
distribution: 'corretto'
cache: 'sbt'

Expand Down
1 change: 1 addition & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
java corretto-21.0.3.9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want the lambda runtime to match this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point! Done with 5a95383.

2 changes: 1 addition & 1 deletion cloudformation/cfn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Resources:
- s3:GetObject
Resource: !Sub arn:aws:s3:::${ConfigBucket}/*
Handler: com.gu.anghammarad.Lambda::handleRequest
Runtime: java11
Runtime: java21
MemorySize: 512
Timeout: 30
CodeUri:
Expand Down
Loading