Improve the Config context #11742
Merged
Improve the Config context #11742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: -87 B (-0.01%) Total Size: 867 kB ℹ️ View Unchanged
|
mxdvl
commented
Jun 27, 2024
| } else { | ||
| return JSON.parse(serialised) as Config; | ||
| config = JSON.parse(serialised) as Config; |
There was a problem hiding this comment.
For the keen beans amongs you: consider using valibot to parse this?
arelra
reviewed
Jun 27, 2024
abeddow91
reviewed
Jul 2, 2024
| renderingTarget: Extract<RenderingTarget, 'Web'>; | ||
| darkModeAvailable: boolean; | ||
| updateLogoAdPartnerSwitch: boolean; | ||
| assetOrigin: AssetOrigin; | ||
| } | ||
| | { | ||
| editionId: EditionId; |
There was a problem hiding this comment.
We have a rule in the sand for our context use that Context should be considered global, static, and immutable - Does this violate that?
There was a problem hiding this comment.
No, it does not:
- The immutability is now guaranteed by TS’s
Readonly<T>Utility type; - The edition is static for a given request, you need a different request to get a different edition;
- The edition is global, no component is allowed to have a different edition than the one used in the request.
Note that Edition was previously a candidate for using Context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
ReadOnlyso it’s not inadvertently mutatededitionIdto the configLatestLinksand squash potential bugsWhy?
This pattern, introduced in #8704, has been very useful. This addressed initial concerns from @georgeblahblah, @ioanna0 and myself about redundant data in the HTML. Adding the edition can help reduce deeply drilled props, and reduce bugs, such as in
CardAge