Use ECMAScript modules nearly everywhere (bis) #8535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
2 times, most recently
from
1bf2a2a to
9750681
Compare
|
Size Change: 0 B 🆕 Total Size: 0 B |
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
5 times, most recently
from
a709690 to
8221e46
Compare
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
3 times, most recently
from
f0fa1e3 to
2ac0f21
Compare
mxdvl
commented
Sep 22, 2023
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
3 times, most recently
from
a267a6b to
5ce3b13
Compare
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
2 times, most recently
from
e4405b9 to
4c2a634
Compare
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
9 times, most recently
from
a861787 to
2ae076f
Compare
Unify our files to be mostly ECMAScript modules, rather than mixed, since it is supported in the current LTS version of Node https://nodejs.org/docs/latest-v18.x/api/esm.html CommonJS modules get the explicit `.cjs` / `.cts` extension Jest tests uses the unstable ESM mocking API, which requires mocked modules to be imported after the mock using dynamic imports. https://jestjs.io/docs/ecmascript-modules#module-mocking-in-esm CDK now uses the ESM version of `ts-node` which loads CommonJS for `.cts` files, reducing the difference between tsconfig.json files, which requires `allowImportingTsExtensions` to be true. https://www.typescriptlang.org/tsconfig#allowImportingTsExtensions
- tests use jest’s unstable module mock - CDK uses commonJS explicitly
mxdvl
force-pushed
the
mxdvl/esm-nearly-everywhere
branch
from
2ae076f to
a51c1dc
Compare
This was referenced Sep 28, 2023
|
I think this is best done piecemeal… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Unify nearly all our modules to be ECMAScript modules, since it is supported in the current LTS version of Node https://nodejs.org/docs/latest-v18.x/api/esm.html
CommonJS modules get the explicit
.cjs/.ctsextensionJest tests uses the unstable ESM mocking API, which requires mocked modules to be imported after the mock using dynamic imports.
CDK now uses the ESM version of
ts-nodewhich loads CommonJS for.ctsfiles, reducing the difference between tsconfig.json files, which requiresallowImportingTsExtensionsto be true.Why?
Reduce the amount of different way a module is interpreted based on the extension.
Before:
.jsCommonJS JavaScript.tsESM TypeScript.mjsESM JavaScript (only a few files).tsCommonJS TypeScript (only a few files)After:
.jsESM JavaScript.tsESM TypeScript.cjsCommonJS JavaScript (only a few files).ctsCommonJS Typescript (only a few files)Another go at #8482