Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Non-AWS dependency updates #271

Merged
merged 2 commits into from
Nov 21, 2024
Merged

chore(deps): Non-AWS dependency updates #271

merged 2 commits into from
Nov 21, 2024

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

About this PR

Updates:

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "com.google.auth", artifactId = "google-auth-library-oauth2-http" },
  { groupId = "com.gu.play-secret-rotation", artifactId = "core" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.google.auth", artifactId = "google-auth-library-oauth2-http" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.gu.play-secret-rotation", artifactId = "core" }
  }
]
labels: dependencies, library-update, early-semver-minor, semver-spec-minor, early-semver-major, semver-spec-major, version-scheme:early-semver, commit-count:n:2

Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally in apple-news (see https://github.com/guardian/apple-news/pull/386), and everything worked as expected – happy to merge!

@emdash-ie emdash-ie merged commit 2d261c2 into main Nov 21, 2024
1 check passed
@emdash-ie emdash-ie deleted the update/non_aws branch November 21, 2024 10:49
@emdash-ie
Copy link
Contributor

Unfortunately my testing of this in apple-news was insufficiently thorough! On deploying it to PROD with the resulting release (v16) of this library, breakage became apparent very quickly. (I had missed errors in the logs when testing with apple news in CODE.)

TBC whether this means the release is fundamentally broken: I will do some more testing with apple-news. We may need to rollback or fix this library and issue a new release to replace the latest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant