-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support For Existing PVC #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @paimonsoror, thanks for the PR. Here are a few thing that have to be adjusted as well as a result of putting data
and attachment
under the new storage
key:
charts/vaultwarden/templates/configmap.yaml
lines 37, 38, 40, and 41.charts/vaultwarden/templates/_pvcSpec.tpl
lines 2, 4, and 27.charts/vaultwarden/templates/_helpers.tpl
line 88.charts/vaultwarden/templates/deployment.yaml
lines 43 - 49 should then look like this (to avoid a dangling 2ndvolumes:
key in the template spec):{{- range $pvc := (fromYaml (include "vaultwarden.pvcSpec" .)).volumeClaimTemplates }} volumes: {{- $newName := printf "%s-%s-0" $pvc.metadata.name $.Release.Name }} - name: {{ $pvc.metadata.name }} persistentVolumeClaim: claimName: {{ $newName }} {{- end }}
Reconcile change requests from guerzon#133
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added support for existing PVC's. This is a more up to date version of a lot of the enhancements made in the following PR, but recreated for a more fresh PR #19 .
Note:
This is a breaking change as the
data
andattachment
objects have been moved under astorage
key.