Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support For Existing PVC #133

Merged
merged 22 commits into from
Nov 30, 2024
Merged

Adding Support For Existing PVC #133

merged 22 commits into from
Nov 30, 2024

Conversation

paimonsoror
Copy link
Contributor

@paimonsoror paimonsoror commented Nov 29, 2024

Added support for existing PVC's. This is a more up to date version of a lot of the enhancements made in the following PR, but recreated for a more fresh PR #19 .

Note:

This is a breaking change as the data and attachment objects have been moved under a storage key.

Copy link
Owner

@guerzon guerzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @paimonsoror, thanks for the PR. Here are a few thing that have to be adjusted as well as a result of putting data and attachment under the new storage key:

  1. charts/vaultwarden/templates/configmap.yaml lines 37, 38, 40, and 41.
  2. charts/vaultwarden/templates/_pvcSpec.tpl lines 2, 4, and 27.
  3. charts/vaultwarden/templates/_helpers.tpl line 88.
  4. charts/vaultwarden/templates/deployment.yaml lines 43 - 49 should then look like this (to avoid a dangling 2nd volumes: key in the template spec):
          {{- range $pvc := (fromYaml (include "vaultwarden.pvcSpec" .)).volumeClaimTemplates }}
          volumes:
            {{- $newName := printf "%s-%s-0" $pvc.metadata.name $.Release.Name }}
            - name: {{ $pvc.metadata.name }}
              persistentVolumeClaim:
                claimName: {{ $newName }}
          {{- end }}
    

charts/vaultwarden/Chart.yaml Outdated Show resolved Hide resolved
charts/vaultwarden/templates/_podSpec.tpl Outdated Show resolved Hide resolved
charts/vaultwarden/templates/_podSpec.tpl Outdated Show resolved Hide resolved
Copy link
Owner

@guerzon guerzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guerzon guerzon merged commit 28169ab into guerzon:main Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants