Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app.kubernetes.io labels to use $ instead of . in vaultwarden chart #77

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

dolohow
Copy link
Contributor

@dolohow dolohow commented Feb 22, 2024

This commit changes the way the app.kubernetes.io/name and app.kubernetes.io/instance labels are generated in the vaultwarden Helm chart. Previously, the .Values object was used directly within the template expression, which is not allowed by Helm. This change updates the expression to use the $ symbol, which correctly references the current values context.

This commit changes the way the `app.kubernetes.io/name` and `app.kubernetes.io/instance` labels are generated in the vaultwarden Helm chart. Previously, the `.Values` object was used directly within the template expression, which is not allowed by Helm. This change updates the expression to use the `$` symbol, which correctly references the current values context.

Fixes #[issue number] (if applicable)
@initrd
Copy link

initrd commented Feb 22, 2024

Thanks for this. I was not able to do a fresh install with 0.22.2 and for the life of me could not figure out what I was missing, even with the default values in the ConfigMap. Without this fix, the install fails with:

$ helm install vaultwarden guerzon/vaultwarden -f helmrelease-vaultwarden.yaml -f configmap-vaultwarden.yaml --dry-run=client --debug
install.go:214: [debug] Original chart version: ""
install.go:231: [debug] CHART PATH: /Users/ashish/Library/Caches/helm/repository/vaultwarden-0.22.2.tgz

Error: INSTALLATION FAILED: template: vaultwarden/templates/statefulset.yaml:47:6: executing "vaultwarden/templates/statefulset.yaml" at <include "vaultwarden.pvcSpec" .>: error calling include: template: vaultwarden/templates/_pvcSpec.tp
l:9:35: executing "vaultwarden.pvcSpec" at <include "vaultwarden.fullname" .>: error calling include: template: vaultwarden/templates/_helpers.tpl:15:14: executing "vaultwarden.fullname" at <.Values.fullnameOverride>: nil pointer evaluati
ng interface {}.fullnameOverride
helm.go:84: [debug] template: vaultwarden/templates/statefulset.yaml:47:6: executing "vaultwarden/templates/statefulset.yaml" at <include "vaultwarden.pvcSpec" .>: error calling include: template: vaultwarden/templates/_pvcSpec.tpl:9:35:
executing "vaultwarden.pvcSpec" at <include "vaultwarden.fullname" .>: error calling include: template: vaultwarden/templates/_helpers.tpl:15:14: executing "vaultwarden.fullname" at <.Values.fullnameOverride>: nil pointer evaluating inter
face {}.fullnameOverride
INSTALLATION FAILED
main.newInstallCmd.func2
    helm.sh/helm/v3/cmd/helm/install.go:154
github.com/spf13/cobra.(*Command).execute
    github.com/spf13/[email protected]/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
    github.com/spf13/[email protected]/command.go:1068
github.com/spf13/cobra.(*Command).Execute
    github.com/spf13/[email protected]/command.go:992
main.main
    helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
    runtime/proc.go:267
runtime.goexit
    runtime/asm_arm64.s:1197

@guerzon guerzon merged commit 04820b4 into guerzon:main Feb 23, 2024
1 check passed
@guerzon guerzon mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants