Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all layout code out of View (and Toplevel) into a layout helper class #2493

Closed
tig opened this issue Apr 4, 2023 · 1 comment
Closed

Move all layout code out of View (and Toplevel) into a layout helper class #2493

tig opened this issue Apr 4, 2023 · 1 comment
Labels
v2 For discussions, issues, etc... relavant for v2

Comments

@tig
Copy link
Collaborator

tig commented Apr 4, 2023

  • Refactor to a LayoutEngine class or just another file that's just a partial of View
  • Break unit tests apart further
@tig tig added the v2 For discussions, issues, etc... relavant for v2 label Apr 4, 2023
@tig tig moved this to 🆕 New in Terminal.Gui V2 Beta Apr 6, 2023
@tig tig moved this from 🆕 New to 📋 Backlog in Terminal.Gui V2 Beta Apr 13, 2023
@tig tig mentioned this issue Apr 14, 2023
Merged
8 tasks
tig added a commit that referenced this issue Apr 14, 2023
@tig
Fixes #2493. Move all layout code out of View (and Toplevel) into a l…
b4552ee 
…ayout helper class (#2544)

* Comment/warning clean up

* Moved Text and Drawing out

* Moved Layout out

* Removed extra lines

* Removed Mouse out

* Reorgainzed View

* API docs

* removed border.cs

* TopLevel.Resized -> TerminalResized

* Mdi -> Overlapped

* Removed confusing and un-needed WillPresent

* privates -> _

* Tweaked RunLoop API
@tig
Copy link
Collaborator Author

tig commented Apr 14, 2023

Fixed by #2544

@tig tig closed this as completed Apr 14, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Terminal.Gui V2 Beta Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2 For discussions, issues, etc... relavant for v2
Projects
No open projects
Terminal.Gui V2 Beta
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tig