-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why ViewMouse doesn't handle the movable procedure instead of the Adornment? #3342
Comments
What is the end-user use case you are considering here? |
In the BackgroundWorker scenario I use a WorkerApp which is a Toplevel without Border to proof the moveable is also possible. Now it can't move. I already have a solution for this and I'll submit a PR. Maybe you agree with the change that is only 2 or 3 lines. Another end-user is the possibility of the designer can move the views more easily without adding |
Is there any reason why the Padding isn't allowing to move the view if it's the only adornment? It overrides the |
… instead of the Adornment?
|
I actually think it's debatable whether margin should support drag. It's all debatable. I decided it made no sense for padding. |
Sure, but I only referring if the Padding it's the only Adornment. In this case I think clicking in the Padding is possible to move the view, otherwise a view with only a Padding never can move the view if it's moveable. I think it's the right procedure, but I could be wrong. |
Right. Another reason Toplevel as a class was a regrettable design choice. With 'Arrangment' it's an easy fix. |
More context: Margin and Padding are typically invisible to the user. Border typically, literally, shows a border. I believe users will be surprised if they click and drag on something invisible and it starts dragging. See "the principle of least surprise" |
Margin is always invisible unless the effect3D is implemented. Padding could ne not always invisible but could have subviews.
I already saw, thanks. I suggest only the Border to be responsible to move the view. The exception is on views without adornments which the user want make it visible from the superview background color and want move it. If the view has Margin and Border the mouse must be over the Border thickness to could move the view. What do you think? |
I concur regarding Border: I'll change things so only However, I do not think the ability to drag a view with no Border should be built-in. Here's why:
If this Issue is not fixed, there's an alternative if someone wants a non-border view to be movable with the mouse:
For this reason, I'd like to close this issue as "by design'. *Regarding |
Before it was possible to move a
Toplevel
withoutBorder
or aWindow
with/outBorder
. Now onlyAdornment
can handle this, which in my opinion isn't the right behavior. Should be theView
itself responsible to handle this based on theArrangement
setting.So the logic on the
OnMouseEvent
in theAdornment
should be on theOnMouseEvent
of theViewMouse.cs
file.The text was updated successfully, but these errors were encountered: