Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of all 3 drivers call refresh constantly #3761

Closed
tznind opened this issue Sep 26, 2024 · 3 comments · Fixed by #3798
Closed

Latest version of all 3 drivers call refresh constantly #3761

tznind opened this issue Sep 26, 2024 · 3 comments · Fixed by #3798
Labels
bug v2 For discussions, issues, etc... relavant for v2
Milestone

Comments

@tznind
Copy link
Collaborator

tznind commented Sep 26, 2024

Describe the bug

refresh-bug
Clicking the mouse causes about 68 screen refreshes (it does eventually stop)

To Reproduce
This changed recently.

  1. Add a debug counter to UpdateScreen
  2. Click mouse

Expected behavior
Only redraw when something has changed.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@tznind tznind added bug v2 For discussions, issues, etc... relavant for v2 labels Sep 26, 2024
@tig
Copy link
Collaborator

tig commented Sep 26, 2024

I probably did this when I fixed a bunch of repaint logic last week. I focused on WindowsDriver.

@tznind tznind changed the title Latest version of NetDriver refreshes constantly on mouse activity Latest version of NetDriver (and WindowsDriver) refreshes constantly Oct 3, 2024
@tig tig added this to the V2 Beta milestone Oct 6, 2024
@BDisp
Copy link
Collaborator

BDisp commented Oct 15, 2024

@tznind I think you should change the title to reflect that this affect all drivers.

@tznind tznind changed the title Latest version of NetDriver (and WindowsDriver) refreshes constantly Latest version of all 3 drivers call refresh constantly Oct 15, 2024
@tig
Copy link
Collaborator

tig commented Oct 15, 2024

I finally got frustrated with all this enough today. I have started a branch where I finally make

  • layout decoupled from draw
  • enforce that Clear rarely happens
  • ensure drivers minimize full repaints
  • minimize when Draw/OnDrawContent are called

More soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v2 For discussions, issues, etc... relavant for v2
Projects
Status: ✅ Done
3 participants