PositionCursor broke with recent ConsoleDriver changes

[tig]

I can't tell exactly what changed, but in the recent IConsoleDriver work PositionCursor is not working correctly.

The cursor is appearing all over the place when it shouldn't

[tznind]

This is a brute force way to fix this problem in #3837

Each iteration after draw we ask the most focused view where it would like cursor to be. Thoughts?

internal void IterationImpl ()
{
    InputProcessor.ProcessQueue ();

    if (Application.Top != null)
    {
        bool needsDrawOrLayout = AnySubviewsNeedDrawn (Application.Top);

        bool sizeChanged = WindowSizeMonitor.Poll ();

        if (needsDrawOrLayout || sizeChanged)
        {
            // TODO: Test only
            Application.LayoutAndDraw (true);

            Out.Write (OutputBuffer);


+        Application.Top.MostFocused?.PositionCursor ();
+        Out.SetCursorPosition (OutputBuffer.Col,OutputBuffer.Row);
+        Out.SetCursorVisibility (CursorVisibility.Default);
        }
    }



    var swCallbacks = Stopwatch.StartNew ();

    TimedEvents.LockAndRunTimers ();

    TimedEvents.LockAndRunIdles ();

    Logging.IterationInvokesAndTimeouts.Record (swCallbacks.Elapsed.Milliseconds);
}

[tznind]

@BDisp are you able to look into what broke the current PositionCursor?

I have some ideas about how we can improve it but having v2 fixed would be a good baseline place to start.

I suspect it could be down to focus events changing and/or the keyboard/mouse handling code changes altering the order of execution of events?

[tznind]

Seems it was working at 903a886

[tznind]

Hmn actually I am having difficulty reproducing this. I get invisible cursor sometimes on some consoles but that is seperate issue I think

[BDisp]

But its broken using Win or Net?

[tznind]

UICatalog in @tig gif above is showing WindowsDriver but I cannot repro.