Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2539. Add feature to draw menus with or without border. #2556

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Apr 15, 2023

Fixes #2539 - Menu were already using Frame Border but I added an option to draw without border as well. The hack on the Toplevel was causing some unit tests being fail and I disable it. I also re-enable some unit tests in the MenuTests that was commented before.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

menu-with-without-border

@BDisp BDisp requested review from migueldeicaza and tig as code owners April 15, 2023 18:36
@tig
Copy link
Collaborator

tig commented Apr 16, 2023

I actually really like this look!!!

@tig tig merged commit 62746f8 into gui-cs:v2_develop Apr 16, 2023
@BDisp BDisp deleted the v2_menu-with_without-border_2539 branch April 16, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants