-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2578 - Updates mouse events to be relative to View.Bounds
#2920
Fixes #2578 - Updates mouse events to be relative to View.Bounds
#2920
Conversation
View.Bounds
View.Bounds
View.Bounds
View.Bounds
This looks great. If I understand correctly this PR establishes more clearly the idea of bounds (like view client area) and 'frame' i.e. border, padding margin. This is good because it simplifies things and is mostly backwards compatible so shouldn't complicate upgrades from v1 too much. 🎆 🚀 |
This is really fantastic. Much more clear, more readable. Thanks for effort. |
I think this is done. I could add more unit tests... Note the big hack for Toplevel dragging. I decided to not tackle this in this pr but to just hack it until we refactor drag/size per #2537 |
Fixes #2578 - How should MouseEvent work with Margin, Border, and Padding?
View.ScreenToView/ViewToScreen
to be more sensical in the face ofBounds != Frame
.TopLevel
. This needs to change to be handled withinBorder
. See #Discuss - There should only be one (Application.Top
) #2502. Will defineView.Movable
andView.Sizable
that will control whether a view can be dragged and/or resized.Related:
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)