Renames Frame->Adornment; changes Frame to have a Border subclass

[tig]

See this discussion: #2994 (comment)

• Create Margin subclass of Frame
• Create Border subclass of Frame
• Create Padding subclass of Frame
• Improve robustness of Adornment creation
• Border line style inherits from SuperView (if not set explicitly).
• Update/tweak Frames scenario
• Frame->Adornment
• Frames scenario etc... rename
• More/better Adornment unit tests

[tig]

@BDisp take a look! Just a WIP, but...

[BDisp]

In the future if Margin has a different behavior than Frame then you will to sub-class it.

[tig]

Yessir.

I already have one difference: Margin uses SuperView color scheme. Border and padding uses View.

[tig]

I started in on adding subviews to border. It's complicated so I'm not going to do it in this pr. I'll neaten this one up a bit more and merge it and do another for that.

[BDisp]

I started in on adding subviews to border. It's complicated so I'm not going to do it in this pr. I'll neaten this one up a bit more and merge it and do another for that.

Ok, I also trying to use the Padding of the TabView to handle the tan rows and it isn't really easy because all the login for handles with views and sub-views are in View class itself. But I'll continue trying.
Why not change the Frame class name to Adornment. The sub-views that are added to them are still View sub-classes. Thus will not make confusing with the Rect Frame.

[tig]

On the padding thing: it'd be great if you opened an Issue on that. I'd love to dig into it with you with focus (and a simple example, not TabView).

On name: I think you know I've been wishy-washy on Frame vs Adornment as the name. Your comment is helpful. I'll strongly consider it!

[BDisp]

On the padding thing: it'd be great if you opened an Issue on that. I'd love to dig into it with you with focus (and a simple example, not TabView).

I was trying in this PR #2980 but didn't commit/push nothing addressed with Padding. So, you don't want I continue on here?

On name: I think you know I've been wishy-washy on Frame vs Adornment as the name. Your comment is helpful. I'll strongly consider it!

Ok at least I did you reflect about it 😃

[tig]

On the padding thing: it'd be great if you opened an Issue on that. I'd love to dig into it with you with focus (and a simple example, not TabView).

I was trying in this PR #2980 but didn't commit/push nothing addressed with Padding. So, you don't want I continue on here?

When working on architecture, I'm a fan of starting with just unit tests and a very simple Scenario vs. a major change like what needs to happen to TabView. TabView is a pretty complex beast, so yes.

[BDisp]

On name: I think you know I've been wishy-washy on Frame vs Adornment as the name. Your comment is helpful. I'll strongly consider it!

Ok at least I did you reflect about it 😃

I really appreciated for you have reconsider to change from Frame to Adornment. Thanks.

[BDisp]

@tig how about rename the Bounds to ContentArea as it's used on some of the View methods?

[tig]

@tig how about rename the Bounds to ContentArea as it's used on some of the View methods?

• Rename View.Bounds to View.Viewport and add View.ContentSize to enable built-in content scrolling #3169