Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3344. OnResizeNeeded using Top's Bounds for Top. #3383

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Apr 3, 2024

Fixes

Proposed Changes/Todos

  • Only border drags now, not margin.
  • Found, fixed, updated unit tests.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig requested a review from BDisp April 3, 2024 20:11
Copy link
Collaborator

@BDisp BDisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the right way to manage the moveable of the view by handle it only on the Border. If has a Margin then the new position must take it at account. Good work.

@tig tig merged commit 9937771 into gui-cs:v2_develop Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants