Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3847. TabView changes focus to Tab on Layout. #3849

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Nov 24, 2024

Fixes

Proposed Changes/Todos

  • Tab it's only focused if the container view cannot be focused or if user click on a selected tab or navigate to it.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner November 24, 2024 12:58
@tig tig merged commit f6db2fc into gui-cs:v2_develop Nov 26, 2024
4 checks passed
@BDisp BDisp deleted the v2_3847_tabview-focus-fix branch November 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView changes focus to Tab on Layout
2 participants