Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save cached config to standard directories #37

Closed
Siilwyn opened this issue May 7, 2017 · 1 comment · May be fixed by ajesse11x/flightplan#4
Closed

Save cached config to standard directories #37

Siilwyn opened this issue May 7, 2017 · 1 comment · May be fixed by ajesse11x/flightplan#4

Comments

@Siilwyn
Copy link
Contributor

Siilwyn commented May 7, 2017 •
edited
Loading

Instead of placing the configuration file in the home directory it should be placed in the appropriate directory per OS. This introduces a breaking change unless some fallback or migration logic is added. I'd rather not do that because it results in extra code that should be removed in the future.

See this original but reverted PR for context. Thought I would open an issue to give it a place to track and possibly discuss.
@tkellen
Copy link

tkellen commented May 7, 2017

👍 looking forward to seeing your implementation!

@Siilwyn Siilwyn mentioned this issue May 8, 2017
Merged
This was referenced May 30, 2017
Closed
Closed
Siilwyn added a commit that referenced this issue Jul 14, 2017
@Siilwyn
Save cached config to standard directories
a1845cc 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
@Siilwyn Siilwyn closed this as completed Jul 14, 2017
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn
Save cached config to standard directories
5faf2f8 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
7bfa22b 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
707c97d 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
c6737be 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
61c44d5 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
2d75a86 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
0363cd7 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
84ea81b 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
ea7be64 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
90a0a93 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
fbfa50f 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Save cached config to standard directories
ee7bafd 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.

Breaking change: resolves issue #37
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Breaking: Save cached config to standard directories (closes #37)
7f29e82 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.
phated pushed a commit that referenced this issue Dec 17, 2018
@Siilwyn @phated
Breaking: Save cached config to standard directories (closes #37)
61e348b 
Instead of placing the configuration file in the home directory it should be placed in the [appropriate directory](https://wiki.archlinux.org/index.php/XDG_Base_Directory_support) per OS.
@snyk-bot snyk-bot mentioned this issue Oct 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade v8flags from 2.1.1 to 3.1.3 ajesse11x/flightplan
2 participants
@tkellen @Siilwyn