Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml add optional dependencies, jupyter_tools is optional #820

Closed
wants to merge 18 commits into from

Conversation

jdegenstein
Copy link
Collaborator

Opening as a draft PR for now for further consideration and also not intended to merge until PR #812 is complete. Open to naming suggestions for the optional dependencies.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (dba9831) to head (b5f6c72).
Report is 120 commits behind head on dev.

Files with missing lines Patch % Lines
src/build123d/jupyter_tools.py 95.12% 2 Missing ⚠️
src/build123d/operations_generic.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #820      +/-   ##
==========================================
+ Coverage   96.08%   96.72%   +0.64%     
==========================================
  Files          25       25              
  Lines        8499     8577      +78     
==========================================
+ Hits         8166     8296     +130     
+ Misses        333      281      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegenstein jdegenstein marked this pull request as ready for review December 17, 2024 21:01
@victorpoughon
Copy link
Contributor

Hi! I just saw that PR after I was done working on #829. Good changes :) I think maybe you might wanna call it jupyter_display instead of jupyter_tools as that's a bit more clear to what it does. But that's minor.

I see you also added a tests/test_jupyter_tools.py, so I'll probably have to update that in my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants