-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject.toml add optional dependencies, jupyter_tools is optional #820
Conversation
This reverts commit 87c046b.
…ete unused vtk imports
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #820 +/- ##
==========================================
+ Coverage 96.08% 96.72% +0.64%
==========================================
Files 25 25
Lines 8499 8577 +78
==========================================
+ Hits 8166 8296 +130
+ Misses 333 281 -52 ☔ View full report in Codecov by Sentry. |
Hi! I just saw that PR after I was done working on #829. Good changes :) I think maybe you might wanna call it I see you also added a |
Opening as a draft PR for now for further consideration and also not intended to merge until PR #812 is complete. Open to naming suggestions for the optional dependencies.