Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing an SVG file from Inkscape using the labels set from the "Layers and Objects" panel currently requires passing both
label_by="label"
andis_inkscape_label=True
toimport_svg()
.This PR proposes to remove the
is_inkscape_label
parameter and allow usinglabel_by="inkscape:label"
(matching the attribute as it appears in the XML:<path d="..." inkscape:label="foo" />
)The implementation is basically handling the
inkscape:
prefix in thelabel_by
values as a shortcut for the actual{http://www.inkscape.org/namespaces/inkscape}
namespace.This should be future-proof enough to handle more shortcuts for other software in addition to Inkscape if the need arises (as opposed to adding more
use_xxx_label: bool
parameters as per the current approach)