Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objects_sketch.py -> mypy typing improvements #853

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

jdegenstein
Copy link
Collaborator

Solves most issues with the module, but I am not sure about this one:

class BaseSketchObject(Sketch):
...
    def __init__(
        self,
        obj: Compound | Face | None, # added or None, which is not handled well upstream

@jdegenstein jdegenstein marked this pull request as ready for review January 8, 2025 23:19
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (25181f4) to head (4669057).
Report is 20 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #853   +/-   ##
=======================================
  Coverage   96.98%   96.99%           
=======================================
  Files          31       31           
  Lines        8901     8922   +21     
=======================================
+ Hits         8633     8654   +21     
  Misses        268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Jan 9, 2025

If there are places where None isn't handled well you could just leave the typing problem there for now and we can circle back and look into it in depth. The geometry.py module contains many tricky problems do to the separation of geometry and topology - I might do a first pass with a few problems remaining.

@jdegenstein
Copy link
Collaborator Author

@gumyr Sounds good, I went ahead and reverted that change. As far as I know this is ready to merge.

@gumyr gumyr merged commit f358699 into gumyr:dev Jan 9, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants