Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readthedocs fixes to topology inheritance diagram, add mixin classes … #872

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jdegenstein
Copy link
Collaborator

…to topology/__init__.py, delete docs/requirements.txt, streamline workflows using new optional dependencies

…to `topology/__init__.py`, delete docs/requirements.txt, streamline workflows
@jdegenstein jdegenstein requested a review from gumyr January 15, 2025 18:55
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (1b5688a) to head (d78ca93).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #872      +/-   ##
==========================================
+ Coverage   96.38%   96.58%   +0.19%     
==========================================
  Files          31       31              
  Lines        9120     9124       +4     
==========================================
+ Hits         8790     8812      +22     
+ Misses        330      312      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Jan 15, 2025

This looks good to me. @jdegenstein thanks for fixing this and all that you do!

@jdegenstein jdegenstein merged commit 7262ae8 into gumyr:dev Jan 15, 2025
20 checks passed
@jdegenstein jdegenstein deleted the rtd_fixes branch January 15, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants