Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use BRep_Builder for single face shell #875

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Jan 17, 2025

Tried making a shell from the single curved face of a cone, got segfault from BRepBuilderAPI_MakeShell. BRep_Builder seems to work fine in that case.
I'm not sure this is a 100% reliable solution but according to the tests it's not worse.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (d78ca93) to head (d0d1a44).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #875      +/-   ##
==========================================
+ Coverage   96.58%   96.61%   +0.03%     
==========================================
  Files          31       31              
  Lines        9124     9138      +14     
==========================================
+ Hits         8812     8829      +17     
+ Misses        312      309       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Jan 23, 2025

Oh, sorry I split the test_direct_api.py file into 32 separate files which breaks this PR. It should be easy to fix though as the content of the tests hasn't changed so test_shells.py should be the new home of this test.

Otherwise, thanks for this change. This lower level implementation looks better in handling the case of a non-planar face which doesn't seem like it should be too difficult.

@snoyer
Copy link
Contributor Author

snoyer commented Jan 23, 2025

I can't fix it right now but you should have write access to the PR branch if you want to resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants