Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporters3d.py -> add "build123d" to exported step files, change step "Name" to build123d label #876

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

jdegenstein
Copy link
Collaborator

This appears to work in OCP 7.8+ now.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (d78ca93) to head (9ce9306).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #876      +/-   ##
==========================================
+ Coverage   96.58%   96.61%   +0.03%     
==========================================
  Files          31       31              
  Lines        9124     9139      +15     
==========================================
+ Hits         8812     8830      +18     
+ Misses        312      309       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegenstein jdegenstein marked this pull request as ready for review January 19, 2025 21:11
@jdegenstein jdegenstein requested a review from gumyr January 19, 2025 21:11
@jdegenstein
Copy link
Collaborator Author

Changes STEP file header from:

ISO-10303-21;
HEADER;
FILE_DESCRIPTION(('Open CASCADE Model'),'2;1');
FILE_NAME('Open CASCADE Shape Model','2025-01-18T15:53:37',('Author'),('Open CASCADE'),
  'Open CASCADE STEP processor 7.8','Open CASCADE 7.8','Unknown');
...

To:

ISO-10303-21;
HEADER;
FILE_DESCRIPTION(('Open CASCADE Model'),'2;1');
FILE_NAME('Open CASCADE Shape Model','2025-01-18T15:54:27',('Author'),(
    'Open CASCADE'),'Open CASCADE STEP processor 7.8','build123d',
  'Unknown');
...

@jdegenstein jdegenstein changed the title exporters3d.py -> add build123d to exported steps exporters3d.py -> add "build123d" to exported step files, change step "Name" to build123d label Jan 21, 2025
@jdegenstein jdegenstein merged commit 5e6f3b3 into gumyr:dev Jan 21, 2025
20 checks passed
@jdegenstein jdegenstein deleted the tagged_step branch January 21, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant