Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix warnings on console #47

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: fix warnings on console #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions redash-searcher-web/components/HighlightedQuery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const HighlightQueryInner = ({ highlight, attribute, hit }: any) => {
{isExpanded && (
<EuiButtonIcon
display="empty"
aria-label="collapse"
iconType={"arrowUp"}
onClick={() => setIsExpanded(!isExpanded)}
style={{ margin: "10px auto", display: "block" }}
Expand All @@ -55,6 +56,7 @@ const HighlightQueryInner = ({ highlight, attribute, hit }: any) => {
{!isExpanded && (
<EuiButtonIcon
display="empty"
aria-label="expand"
iconType={"arrowDown"}
onClick={() => setIsExpanded(!isExpanded)}
style={{ margin: "10px auto", display: "block" }}
Expand Down
27 changes: 13 additions & 14 deletions redash-searcher-web/components/Hit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,19 @@ const Hit: React.FC<HitProps> = ({ hit }: HitProps) => {
/>
}
title={
<div>
<h2>
{hit.name}
<EuiButtonEmpty
iconType={"lensApp"}
href={`${REDASH_URL}/queries/${hit.id}/source`}
target="_blank"
style={{ margin: "0 8px" }}
contentProps={{ style: { padding: "0" } }}
>
Open Redash
</EuiButtonEmpty>
</h2>
</div>
<>
{hit.name}
<EuiButtonEmpty
aria-label="open-redash"
iconType={"lensApp"}
href={`${REDASH_URL}/queries/${hit.id}/source`}
target="_blank"
style={{ margin: "0 8px" }}
contentProps={{ style: { padding: "0" } }}
>
Open Redash
</EuiButtonEmpty>
</>
}
description={hit.description}
>
Expand Down