Skip to content

Commit

Permalink
Further ratchet down the error margins
Browse files Browse the repository at this point in the history
  • Loading branch information
David McGuire committed Apr 18, 2015
1 parent b33b796 commit 29011bd
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ class ReceiverSuite extends TestSuiteBase with Timeouts with Serializable {

// recordedData size should be close to the expected rate
// use an error margin proportional to the value, so that rate changes don't cause a brittle test
val minExpectedMessages = expectedMessages - 0.05 * expectedMessages
val maxExpectedMessages = expectedMessages + 0.05 * expectedMessages
val minExpectedMessages = expectedMessages - 0.01 * expectedMessages
val maxExpectedMessages = expectedMessages + 0.01 * expectedMessages
val numMessages = recordedData.size
assert(
numMessages >= minExpectedMessages && numMessages <= maxExpectedMessages,
Expand All @@ -196,8 +196,8 @@ class ReceiverSuite extends TestSuiteBase with Timeouts with Serializable {

// XXX Checking every block would require an even distribution of messages across blocks,
// which throttling code does not control. Therefore, test against the average.
val minExpectedMessagesPerBlock = expectedMessagesPerBlock - 0.05 * expectedMessagesPerBlock
val maxExpectedMessagesPerBlock = expectedMessagesPerBlock + 0.05 * expectedMessagesPerBlock
val minExpectedMessagesPerBlock = expectedMessagesPerBlock - 0.01 * expectedMessagesPerBlock
val maxExpectedMessagesPerBlock = expectedMessagesPerBlock + 0.01 * expectedMessagesPerBlock
val receivedBlockSizes = recordedBlocks.map { _.size }.mkString(",")

// the first and last block may be incomplete, so we slice them out
Expand Down

0 comments on commit 29011bd

Please sign in to comment.