-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: indexing and autoread retoggle #115
fix: indexing and autoread retoggle #115
Conversation
Added demo gifs for convenience but feel free to pull and check out flow to see if anything is off. Second part of #113 will have to come in separate pr. |
looks awesome! :3 |
Would it be reasonable to ignore trying to mark un-read within post after it was just done so? If not navigation might have to be switched to work by skipping over posts if show read isn't turned on. Alternatively maybe keep a backup so it could be re-added to list. For example currently if autoread is on or mark read manually each post essentially drops from navigation list when using |
@coolsloth55 sorry I don't think I understand what you mean while inside of post, if you mark it as read and then immediately as unread — the possibly problematic / annoying to implement part (right?) if read posts are hidden, you suggest to skip over posts — not sure which posts you mean to skip the last sentence I don't get also |
Design decision, there's no indication currently when viewing the post whether it's been read. Similar to #112 you might unknowingly un-read a post. A navigation side affect is a follows since you can only mark read currently and not undo ::
If item-2 is read do we want allow undoing read in post view? |
ohhhhh I see! yeah, now that you mention it, it is a bit missing ux to not know whether the opened post is marked as read or not having the marker will solve the ambiguity, but it then implies being able to undo it. it's not necessary, but would be surprising behavior if you see a toggle, and can only toggle it to one side |
Might be easy to prefix/postfix post title with something like
Toggle definitely make sense then especially since it's "manual" and matches list view read. |
yes! I like the idea of a prefix, (probably) easy to implement and does the job |
…st, and added read indication to post view
omg that's so nice :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @coolsloth55, couple of small comments but the core of it looks good. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @coolsloth55, couple of small comments but the core of it looks good. 🎉
thanks @coolsloth55 |
I'm using this now and WOW, what a pleasure! this RSS reader was already way better than any alternatives I found, but thanks to both of you it has become even more top tier. phenomenal!! |
Appreciate the comment @Axlefublr, thank you for all your feedback and bug reports. Shout out and thanks to @coolsloth55 for all their contributions! |
Mark Read
Show Read Version
Indexing For AutoRead
Misc
I didn't notice this first time around but page down is actually
f/pgdn
page down. Switched to F as it's annoying if you favorite and it moves your screen.