Remove Result for functions that are always Ok #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bunch of redundant error handling in our renderer that was needed before this due to this crate returning
Result<()>
for a lot of functions that didn't have any failure conditions.This wasn't very ergonomic to work with and it is not ideal to handle errors that can never happen, so this PR removes
Result
return values for vk-mem functions that returned void.One could argue that more functions that return simple structs and values also here don't need to return it through a
Result<value>
if this crate always returnsOk
on it, but chose to just do it for the simple void functions here which was the most obvious ones.