Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Result for functions that are always Ok #36

Merged

Conversation

repi
Copy link
Contributor

@repi repi commented Jul 7, 2020

We had a bunch of redundant error handling in our renderer that was needed before this due to this crate returning Result<()> for a lot of functions that didn't have any failure conditions.

This wasn't very ergonomic to work with and it is not ideal to handle errors that can never happen, so this PR removes Result return values for vk-mem functions that returned void.

One could argue that more functions that return simple structs and values also here don't need to return it through a Result<value> if this crate always returns Ok on it, but chose to just do it for the simple void functions here which was the most obvious ones.

@repi
Copy link
Contributor Author

repi commented Jul 7, 2020

As this changes the API, I think it would motivate/require a 0.3.0 release so users upgrade explicit to it and change their code that is using the functions in question

@gwihlidal gwihlidal merged commit e0d3daf into gwihlidal:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants