Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded vendored VMA #50

Closed
wants to merge 2 commits into from
Closed

Conversation

dylanede
Copy link

This upgrades the commit of Vulkan Memory Allocator referred to by this project, and performs simple adjustments to the Rust source to be compatible with this new version (including regenerating the bindings using newer Vulkan headers), as well as adding enum variants corresponding to newly introduced variants in VMA.

@HindrikStegenga
Copy link

This PR breaks packaging as you forgot to change the path in Cargo.toml.

@icanwalkonwater
Copy link

Is this PR dead ? Because it updates the vulkan headers of the wrapper to vulkan 1.2.

As of today if you try to create a VMA instance by passing it a vulkan_api_version equal or above 1.2 it will straight up crash because VK_VERSION_1_2 was not defined during the build, effectively gatekeeping us from using a minimum of vk1.2 in our projects.

@Neo-Zhixing
Copy link
Collaborator

Closed by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants